MBS-9372: Allow notes from voting-disabled editor #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwiencek
requested changes
Jun 12, 2017
root/edit/cannot_vote.tt
Outdated
| @@ -0,0 +1,8 @@ | |||
| [% WRAPPER 'layout.tt' full_width=1 title=l('Error Voting Edit') %] | |||
| <h1>[% l('Error Voting Edit') %]</h1> | |||
There was a problem hiding this comment.
"Error Voting on Edits" sounds more correct to me.
root/edit/cannot_vote.tt
Outdated
| [% WRAPPER 'layout.tt' full_width=1 title=l('Error Voting Edit') %] | ||
| <h1>[% l('Error Voting Edit') %]</h1> | ||
| <p> | ||
| [% l('You’re currently not allowed to vote because an admin has revoked your privileges. |
There was a problem hiding this comment.
Could we use the same message that's in root/layout.tt? I guess the only difference is s/vote/edit or vote/. But that seems perfectly fine and then won't have to be translated again.
There was a problem hiding this comment.
A macro for this <p> might be even better.
There was a problem hiding this comment.
Oops, the message is actually displayed twice. I simplified the message instead in 03f2172
mwiencek
approved these changes
Jun 12, 2017
Prior to this patch, if admin revoked editing/voting privileges of any editor, this editor would not be able to submit edit notes, since it would be incidentally disallowed at the same time as votes. This patch refines permissions to submit edit notes and votes so to allow submitting edit notes when editor is editing/voting-disabled and no vote is submitted. If any vote is submitted at the same time, edit notes are rejected as well and an error page is returned.
|
Fixed up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug MBS-9372: Revoking editing/voting editor rights also renders them unable to write edit notes.
Prior to this patch, if admin revoked editing/voting privileges of any editor, this editor would not be able to submit edit notes, since it would be incidentally disallowed at the same time as votes.
This patch refines permissions to submit edit notes and votes so to allow submitting edit notes when editor is editing/voting-disabled and no vote is submitted. If any vote is submitted at the same time, edit notes are rejected as well and an error page is returned.