Yade: init at 2017.01a #26651
Closed
Yade: init at 2017.01a #26651
+143
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
Jun 16, 2017
| name = "minieigen"; | ||
|
|
||
| src = pkgs.fetchurl { | ||
| url = "https://github.com/eudoxos/minieigen/archive/master.zip"; |
There was a problem hiding this comment.
This is not a stable url. Either refer to a commit or a release. Also use fetchFromGitHub.
|
|
||
| minieigen = minieigen; | ||
|
|
||
| yade = stdenv.mkDerivation rec { |
There was a problem hiding this comment.
this attribute needs to be referenced somewhere. For example in ./pkgs/top-level/all-packages.nix.
qknight
reviewed
Jun 19, 2017
| in | ||
|
|
||
|
|
||
| minieigen = minieigen; |
|
The pull request targets branch |
|
I expect #26873 supercedes this PR, please re-open if I'm mistaken. |
Janik-Haag
added
the
12. first-time contribution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)