Fixing attribute name mistake: setguid => setgid #26657
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vcunat
approved these changes
Jun 16, 2017
|
It seems a safe change to me, but let's wait if you prefer. Typo introduced in e92b840. |
|
@vcunat okay, I tested the build and I also verified that when (I also tested that the other common setuid and setcap wrappers work correctly, not all, just a sanity check) Thanks for the quick review. |
vcunat
added a commit
that referenced
this pull request
Jun 17, 2017
vcunat
added a commit
that referenced
this pull request
Jun 17, 2017
|
Picked to 17.03, too, as the situation in the surrounding code seems very much the same. |
ambrop72
pushed a commit
to ambrop72/nixpkgs
that referenced
this pull request
Jun 21, 2017
Fixes NixOS#26611. (cherry picked from commit c416641)
adrianpk
added a commit
to adrianpk/nixpkgs
that referenced
this pull request
May 31, 2024
Fixes NixOS#26611. (cherry picked from commit c416641)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Fixing a coding mistake in the changes made to
nixos/modules/security/wrappers/default.nixfor the setcap wrapper support.The mistake was related to conditional logic checking if a
setuidorsetgidattribute was set on an argument set and if so if either weretrue. The mistake was thatsetgidwas misspelled assetugidwhich means that if a wrapper program hadsetuid = falsebutsetgid = trueand nopermissionsattribute in the argset it would use the defaultmkSetuidProgramconfiguration.This is not correct behavior because it means a program's user or group if neither of those attributes were not set in the argset would be defaulted to
rootand this is dangerous.The fix is to correct the spelling mistake.
This was caught while investigating #26611.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)I have yet to build and test this, I will probably get to that tonight, so don't merge until that has happened.