kodiPlugins: fix path for shared object links #26653
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
Jun 17, 2017
| @@ -77,7 +77,7 @@ rec { | |||
| # them. Symlinking .so, as setting LD_LIBRARY_PATH is of no use | |||
| installPhase = let n = namespace; in '' | |||
| make install | |||
| ln -s $out/lib/addons/${n}/${n}.so.${version} $out/${pluginDir}/${n}.so | |||
| ln -s $out/lib/addons/${n}/${n}.so.${version} $out/${pluginDir}/${n}/${n}.so.${version} | |||
There was a problem hiding this comment.
Is it possible that sometimes both symlinks are needed?
There was a problem hiding this comment.
I don't think so, Kodi looks for this exact path for each plugin.
Signed-off-by: Jonathan Rudenberg <jonathan@titanous.com>
titanous
force-pushed
the
fix-kodi-plugins
branch
from
6048bde
to
587451a
Compare
|
@edwtjo merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
513e66e broke plugins with shared objects because the path was wrong, this fixes it.
/cc @edwtjo
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)