Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests fail on Strawberry Perl 5.24.1.1 (64bit) Windows 10 due to missing rm/diff #60

Closed
jfroebe opened this issue Apr 5, 2017 · 5 comments
Closed

Tests fail on Strawberry Perl 5.24.1.1 (64bit) Windows 10 due to missing rm/diff #60

jfroebe opened this issue Apr 5, 2017 · 5 comments

Comments

@jfroebe
Copy link

jfroebe commented Apr 5, 2017

Platform: Strawberry Perl 5.24.1.1 (64bit) Windows 10
Inline::C version: 0.76

Test t/parse-pegex.t is looking for platform specific rm and diff. These should be replaced with perl implementations.

inline-c_testfailures.txt
@nanis
Copy link

nanis commented May 9, 2017 •
edited

Same issue with Visual Studio 2013 compiled perl 5.24.1 on Windows 10. At the very least, tests should be skipped if external programs are not found:

t\parse-pegex.t .......... 9/? 'diff' is not recognized as an internal or external command,
operable program or batch file.
'diff' is not recognized as an internal or external command,
....
diff' is not recognized as an internal or external command,
operable program or batch file.

Workaround

Visual Studio optionally offers to install Git which installs some useful utilities (including perl) in c:\Program Files\git\usr\bin which is not usually added to %PATH%. Appending that directory to the path:

path=%path%;"c:\Program Files\git\usr\bin"

results in

$ prove -vb t\parse-pegex.t
Test Summary Report
-------------------
t\parse-pegex.t (Wstat: 0 Tests: 24 Failed: 0)
  TODO passed:   4, 7-9
Files=1, Tests=24,  3 wallclock secs ( 0.11 usr +  0.02 sys =  0.13 CPU)
Result: PASS

@perlpunk
Copy link
Collaborator

thanks, i created PR #66

@perlpunk perlpunk mentioned this issue May 19, 2017
Merged
@perlpunk
Copy link
Collaborator

@nanis @jfroebe we just released Inline::C 0.78, could you test if it works now?

@nanis
Copy link

nanis commented Jun 16, 2017 

C:\...\Temp> cpanm Inline::C
...
Building and testing Inline-C-0.78 ... OK
Successfully installed Inline-C-0.78

Thank you very much and apologies for the late response.

@perlpunk
Copy link
Collaborator

cool, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nanis @jfroebe @perlpunk