Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.ps_mem: init at 3.9 #26655

Merged
merged 1 commit into from Jun 18, 2017
Merged

pythonPackages.ps_mem: init at 3.9 #26655

merged 1 commit into from Jun 18, 2017

Conversation

ghost
Copy link

@ghost ghost commented Jun 16, 2017

Motivation for this change

A utility to accurately report the in core memory usage for a program
https://github.com/pixelb/ps_mem/blob/master/README.md

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@@ -8461,6 +8461,19 @@ in {
};
};

ps_mem = buildPythonPackage rec {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it does not look like a library too me. Can you move it out of python-packages.nix into its own directory (ex: ./pkgs/tools/system) and reference it in all-packages.nix.

@ghost
Copy link
Author

ghost commented Jun 18, 2017

@Mic92 Done, thanks!

@Mic92 Mic92 merged commit ce32737 into NixOS:master Jun 18, 2017
@ghost ghost deleted the master3 branch June 18, 2017 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants