New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stomp #231
Merged
Merged
Stomp #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WoW! Must have a look into this more closely!
James Mills / prologic
E: prologic@shortcircuit.net.au
W: prologic.shortcircuit.net.au
…On Mon, Jun 5, 2017 at 9:38 PM, Kathy Church ***@***.***> wrote:
This implements a STOMP client, useful for sending/receiving messages to
rabbitmq, activemq, etc. It also supports connecting to the STOMP server
through an HTTP proxy. Basic tests and example included.
------------------------------
You can view, comment on, or merge this pull request online at:
#231
Commit Summary
- Add support for STOMP protocol
- cleanup
- Test params from env, tests for http proxy and no ssl context
- sample credentials in example
- better default ssl version, pep8
- Changes per review comments
File Changes
- *A* circuits/protocols/stomp/__init__.py
<https://github.com/circuits/circuits/pull/231/files#diff-0> (8)
- *A* circuits/protocols/stomp/client.py
<https://github.com/circuits/circuits/pull/231/files#diff-1> (289)
- *A* circuits/protocols/stomp/events.py
<https://github.com/circuits/circuits/pull/231/files#diff-2> (107)
- *A* circuits/protocols/stomp/transport.py
<https://github.com/circuits/circuits/pull/231/files#diff-3> (88)
- *A* examples/stompclient.py
<https://github.com/circuits/circuits/pull/231/files#diff-4> (99)
- *M* setup.py
<https://github.com/circuits/circuits/pull/231/files#diff-5> (1)
- *A* tests/protocols/test_stomp.py
<https://github.com/circuits/circuits/pull/231/files#diff-6> (203)
- *M* tox.ini
<https://github.com/circuits/circuits/pull/231/files#diff-7> (2)
Patch Links:
- https://github.com/circuits/circuits/pull/231.patch
- https://github.com/circuits/circuits/pull/231.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#231>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABOv-oC9PoennKbkPDywK5mErojVi5jDks5sBGc3gaJpZM4NwiSm>
.
|
Codecov Report
@@ Coverage Diff @@
## master #231 +/- ##
=========================================
Coverage ? 74.48%
=========================================
Files ? 84
Lines ? 7034
Branches ? 0
=========================================
Hits ? 5239
Misses ? 1795
Partials ? 0
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a STOMP client, useful for sending/receiving messages to rabbitmq, activemq, etc. It also supports connecting to the STOMP server through an HTTP proxy. Basic tests and example included.