Add travis testing for OSX and fix locale tests. #2824
Conversation
| env: NMODE=nikola | ||
| python: '3.6' | ||
| before_install: | ||
| - brew upgrade pyenv |
There was a problem hiding this comment.
Why not brew install python3; brew link python3? I’m not a fan of pyenv myself, and the Homebrew python is pretty good. Plus, it doesn’t need to be updated to track Python patch versions (and minor versions, too)
There was a problem hiding this comment.
I considered that but it doesn't provide any control over which specific version of python is running and it means that changes in Homebrew could unexpectedly break builds.
The crux of it is that Travis support for Python builds on macOS is a little lacking and this was the simplest, reliable, reproducible way that I could come up with to get things to build (there are a lot of failed attempts squashed into this commit).
There was a problem hiding this comment.
You could argue the same about Travis CI’s images (in fact, I had to take down a C project of mine because Travis introduced random crashes I can’t debug in any way).
I’m going to merge this and experiment using Python from Homebrew. (and if it breaks, I’ll be the first to know as that’s how I’m working on my Mac).
There was a problem hiding this comment.
As an aside, I was also not a fan of pyenv for quite a while but pyenv-virtualenv combined with pyenv local has really brought me around.
CHANGES.txt
Outdated
| @@ -47,6 +47,7 @@ Bugfixes | |||
|
|
|||
| * Use inheritance tree when looking for theme engine (Issue #2816) | |||
| * Fix unbound variable error in locale guessing (Issue #2806) | |||
| * Tests run on OSX. | |||
There was a problem hiding this comment.
This should go into “New in master”, I’ll fix it when merging.
(PS. macOS*)
|
There's one disadvantage for Travis macOS builds: they take forever to start. Take a look at the OSX Build Backlog here: https://www.traviscistatus.com/ |
Pull Request Checklist
Description
Fix locale tests on OSX and add OSX build to Travis.