Use Flask pika connection pooler #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. 👍 If I had to point out something, adding the version of Flask-Pika to |
|
|
alastair
reviewed
Jun 6, 2017
| if "RABBITMQ_HOST" not in app.config: | ||
| app.logger.error("RabbitMQ host:port not defined. Sleeping 2 seconds, and exiting.") | ||
| sleep(2) | ||
| sys.exit(-1) | ||
|
|
||
| FLASK_PIKA_PARAMS = { |
There was a problem hiding this comment.
should these be here, or in config.py?
There was a problem hiding this comment.
Normally it should be in config.py, but that is already getting cluttered. When I work on deployment I'll see about adding production config for the pooling settings.
| return | ||
| except pika.exceptions.ConnectionClosed: | ||
| except Exception as err: |
There was a problem hiding this comment.
Why the broadening of the exception? Is there not a generic flask-pika exception that we can catch here?
There was a problem hiding this comment.
Not really. Pika exceptions are generally a mess, which is why I catch broad exceptions for as few lines as possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As stated on the tin -- there are still a ton of waring messages that are supposed to be benign. At least the code works every time, regardless of the various messages. That is an improvement. :)