Flowr no jquery #2776
Merged
Flowr no jquery #2776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ralsina flowr.js should be a symlink. Otherwise, it’s not kept up-to-date with Bower, and stuff like this happens. |
|
@Kwpolska updated from where? It's basically a fork at this point. |
|
Wait, so you hacked flowr not to require jQuery? |
|
Exactly :-) |
|
IMO it’d be better to focus on #2777 than use a stop-gap measure. But if you want this now, feel free to merge with no-reviews override. |
|
That's also happening soon, it's orthogonal. Merging, then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch makes Flowr.js work without JQuery, and in the base theme. Therefore:
I am hesitant to make the bootstrap theme use this, since it may break someone's derived theme.