Skip to content

common-updater-script: fix error handling #25919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2017

Conversation

taku0
Copy link
Contributor

@taku0 taku0 commented May 19, 2017

Motivation for this change

common-updater-script uses cmp command to check errors, but it cannot find cmp, so results in the following log file:

/nix/store/ys5l41pwfja3lyjaw9mf9ia9ivi8y8kl-common-updater-scripts/bin/.update-source-version-wrapped: line 55: cmp: command not found
/nix/store/ys5l41pwfja3lyjaw9mf9ia9ivi8y8kl-common-updater-scripts/bin/.update-source-version-wrapped: line 69: cmp: command not found
/nix/store/ys5l41pwfja3lyjaw9mf9ia9ivi8y8kl-common-updater-scripts/bin/.update-source-version-wrapped: line 86: cmp: command not found

This PR adds diffutils as a dependency to fix it.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

cc: @dezgeg


Sorry, something went wrong.

diffutils is required for cmp command
@dezgeg dezgeg merged commit 7868cb8 into NixOS:master May 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants