radare2: 1.4.0 -> 1.5.0 #26322
Closed
radare2: 1.4.0 -> 1.5.0 #26322
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pSub
added
the
8.has: package (update)
|
there are two broken symlinks in the radare package: |
|
Odd. I build on Fedora 25 and then those symlinks aren't even created when building with Nix, so I missed them. It seems a fairly recent addition (pre-1.4.0). |
|
I built it with the pre-release version of nix. This version is also used on hydra. The symlinks are in bin. |
|
Right. The radare2 Makefile says: so I guess that is where it goes wrong. |
|
You can make a patch to copy both scripts instead and sent it also to upstream. This should be never the correct way to install those scripts. If the scripts are only required for development, they can be removed instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
new version
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)