Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

radare2: 1.4.0 -> 1.5.0 #26322

Closed
wants to merge 1 commit into from
Closed

radare2: 1.4.0 -> 1.5.0 #26322

wants to merge 1 commit into from

Conversation

armijnhemel
Copy link
Contributor

Motivation for this change

new version

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Jun 2, 2017

there are two broken symlinks in the radare package:

r2-docker -> /build/radare2-1.5.0/sys/r2-docker.sh
r2-indent -> /build/radare2-1.5.0/sys/indent.sh

@armijnhemel
Copy link
Contributor Author

Odd. I build on Fedora 25 and then those symlinks aren't even created when building with Nix, so I missed them. It seems a fairly recent addition (pre-1.4.0).

@Mic92
Copy link
Member

Mic92 commented Jun 3, 2017 •
edited

I built it with the pre-release version of nix. This version is also used on hydra. The symlinks are in bin.
/build is the new sandbox directory of nix, when building packages.

@armijnhemel
Copy link
Contributor Author

Right.

The radare2 Makefile says:

    ln -fs "${PWD}/sys/indent.sh" "${DESTDIR}${BINDIR}/r2-indent"
    ln -fs "${PWD}/sys/r2-docker.sh" "${DESTDIR}${BINDIR}/r2-docker"

so I guess that is where it goes wrong.

@Mic92
Copy link
Member

Mic92 commented Jun 3, 2017 •
edited

You can make a patch to copy both scripts instead and sent it also to upstream. This should be never the correct way to install those scripts. If the scripts are only required for development, they can be removed instead.

@Mic92 Mic92 closed this in #28361 Aug 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (update)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@armijnhemel @Mic92 @pSub