New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce core theme. #2810
Introduce core theme. #2810
Conversation
GitHub makes it a bit of a pain to review, so here are comments:
|
I’ve had some time to think about this. You see, the existence of a |
@Kwpolska Those are pretty solid points and, for me, they raise the question of what the purpose of the Some of this may be better to discuss in a v8 context where breaking changes might be permitted in themes. |
Including other themes would increase bloat (and our packages are already quite large) and introduce a burden. You see, some of the themes in the index are not well supported, were contributed by other people, and we don’t have the resources to look after all of them. So we have a repository that everyone can contribute to, and where everyone can find a theme they like. v8 should probably happen one day, but we’re a bit wary of just making a release to delete stuff… we probably should get it done soon-ish though. That said, I’m not sure I fully agree with your vision for |
Duplicate base to core modify metadata and remove duplicate messages trim and update assets strip things down in core and remove from base update rss files typo feed consolidation feed_helper fixes do not pre-minify carve down base a bit fix translations temporarily move things around to facilitate diffs add some links to fix diffs add some links to fix diffs rst.css diverge less back to the new names readd cz fix bundle unremove annotation_helper remove unneeded assets fix translation messages modify jinjify to handle core and possible bootstrap deletion use minified assets jinjify and fix metadata for jinja themes Update changelog resynchronize base with core ipython.min.css html5shiv from bower
I‘m closing this. If you still want to make a |
Pull Request Checklist
Description
Closes #2744
Introduces new
core
andcore-jinja
themes to serve as lower level starting points for theme developers. These themes remove nearly all style and js based functionality from base. Additionally,base
andbase-jinja
are redirected to derive fromcore
andcore-jinja
respectively.