Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pymol: added Pmw + python version bump #26317

Merged
merged 3 commits into from Jun 2, 2017
Merged

pymol: added Pmw + python version bump #26317

merged 3 commits into from Jun 2, 2017

Conversation

Mounium
Copy link
Contributor

@Mounium Mounium commented Jun 1, 2017

Motivation for this change

Missed a .desktop file

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@Mounium, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fpletz to be a potential reviewer.

@FRidh
Copy link
Member

FRidh commented Jun 2, 2017

Is python3 (i.e., python36) not possible?

@Mounium
Copy link
Contributor Author

Mounium commented Jun 2, 2017

Last time I tried it failed with python36 but now it compiled without a problem. Currently, I'm trying to add an optional module (Pmw) to make the program complete, will modify this pull request when I'm ready.

@Mounium Mounium closed this Jun 2, 2017
@Mounium Mounium reopened this Jun 2, 2017
@Mounium Mounium changed the title pymol: python 2.7 -> python 3.5 + desktop icon pymol: added Pmw + python version bump Jun 2, 2017
@FRidh FRidh mentioned this pull request Jun 2, 2017
7 tasks
@Mic92 Mic92 merged commit cb2f0d3 into NixOS:master Jun 2, 2017
@Mounium Mounium deleted the pymol branch June 2, 2017 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants