Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bluez: 5.43 -> 5.45 #26019

Closed
wants to merge 2 commits into from
Closed

bluez: 5.43 -> 5.45 #26019

wants to merge 2 commits into from

Conversation

armijnhemel
Copy link
Contributor

Motivation for this change

new version, also gatttool is no longer built by default

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@armijnhemel, thanks for your PR! By analyzing the history of the files in this pull request, we identified @asymmetric, @aristidb and @ierton to be potential reviewers.

@asymmetric
Copy link
Contributor

Should we completely remove the line then, or is it best practice to comment it out?

@armijnhemel
Copy link
Contributor Author

I am not the maintainer and I am not sure whether or not gatttool is actually used by someone, so I just left it in there for now. If no one is using it, then probably best to just remove the line completely.

@asymmetric
Copy link
Contributor

asymmetric commented May 23, 2017 •
edited

Or at least adding a comment in the code explaining the situation.

@armijnhemel
Copy link
Contributor Author

Added a comment about the commented line.

asymmetric
asymmetric reviewed May 23, 2017
View reviewed changes
Copy link
Contributor

@asymmetric asymmetric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'll wait to see if the other people mentioned in the PR know what the best thing to do is here.

@armijnhemel
Copy link
Contributor Author

Any news?

@fpletz
Copy link
Member

fpletz commented Aug 31, 2017

There are links in bin that point to wrong paths (../test):

total 941
-r-xr-xr-x  2 root root 195392 Jan  1  1970 bccmd
-r-xr-xr-x  2 root root  43400 Jan  1  1970 bluemoon
-r-xr-xr-x  2 root root 166744 Jan  1  1970 bluetoothctl
lrwxrwxrwx 11 root root     31 Jan  1  1970 bluetoothd -> ../libexec/bluetooth/bluetoothd
lrwxrwxrwx 11 root root     20 Jan  1  1970 bluez-list-devices -> ../test/list-devices
lrwxrwxrwx 11 root root     25 Jan  1  1970 bluez-monitor-bluetooth -> ../test/monitor-bluetooth
lrwxrwxrwx 11 root root     20 Jan  1  1970 bluez-simple-agent -> ../test/simple-agent
lrwxrwxrwx 11 root root     20 Jan  1  1970 bluez-test-adapter -> ../test/test-adapter
lrwxrwxrwx 11 root root     19 Jan  1  1970 bluez-test-device -> ../test/test-device
lrwxrwxrwx 11 root root     24 Jan  1  1970 bluez-test-thermometer -> ../test/test-thermometer
-r-xr-xr-x  2 root root  33944 Jan  1  1970 btattach
-r-xr-xr-x  2 root root 666392 Jan  1  1970 btmon
-r-xr-xr-x  2 root root  17824 Jan  1  1970 hex2hcd
-r-xr-xr-x  2 root root 100048 Jan  1  1970 l2ping
-r-xr-xr-x  2 root root 118416 Jan  1  1970 l2test
-r-xr-xr-x  2 root root 109768 Jan  1  1970 mpris-proxy
lrwxrwxrwx 11 root root     26 Jan  1  1970 obexd -> ../libexec/bluetooth/obexd
-r-xr-xr-x  2 root root 153888 Jan  1  1970 rctest

@fpletz
Copy link
Member

fpletz commented Sep 18, 2017

Obsolete due to dadb16a.

@fpletz fpletz closed this Sep 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asymmetric asymmetric asymmetric left review comments

@0xABAB 0xABAB 0xABAB approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@armijnhemel @mention-bot @asymmetric @fpletz @0xABAB