Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Definitions #66

Merged
merged 4 commits into from Jun 3, 2017
Merged

Definitions #66

merged 4 commits into from Jun 3, 2017

Conversation

dericed
Copy link
Contributor

@dericed dericed commented May 23, 2017

No description provided.

ffv1.md Outdated
@@ -737,7 +739,7 @@ Slice( ) { |
SliceHeader( ) |
SliceContent( ) |
if (coder_type == 0) |
while (!byte_aligned()) |
while (!byte_aligned( NumBytes )) |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case, Slice() should be Slice ( NumBytes ) (2 places).

I am a bit reluctant to put NumBytes everywhere, it make the read a bit more complex without real value added IMHO, I would remove it from while ( remaining_bits_in_bitstream( NumBytes ) )

Someone else, opinion?

@dericed
Copy link
Contributor Author

dericed commented Jun 2, 2017

I agree with @JeromeMartinez's comment at #66 (comment) and dropped the NumBytes patch. The remaining commits should be easier to gain consensus on. Please re-review.

Copy link
Contributor

@retokromer retokromer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michaelni michaelni merged commit e0f7f75 into FFmpeg:master Jun 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants