New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for VS2013 #2653
Drop support for VS2013 #2653
Conversation
@@ -918,8 +918,8 @@ if(CMAKE_COMPILER_IS_GNUCXX AND HPX_WITH_GCC_VERSION_CHECK) | |||
endif() | |||
|
|||
if(MSVC) | |||
if(NOT (MSVC11 OR MSVC12 OR MSVC14)) | |||
hpx_error("MSVC x64 2012 or higher is required.") | |||
if(NOT (MSVC14)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, however it's inconvenient to have a CMake variable for each MSVC version, a better approach would be the usage of the MSVC_VERSION
variable: if(NOT (MSVC_VERSION LESS 1900))
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's out of the scope of this PR, but feel free to propose those changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it's definitly out of scope, I just wanted to note it so we can pick it up in the future...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
\o/ LGTM, thanks!
No description provided.