Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cyrus-sasl: Add saslauthd service and LDAP support #26419

Merged
merged 2 commits into from
Jul 20, 2017

Conversation

roblabla
Copy link
Contributor

@roblabla roblabla commented Jun 6, 2017

Motivation for this change

I'm currently trying to set up a mail server (well, just a forwarder) with LDAP and Postfix. To this end, I've had to add support to the saslauthd service to NixOS, along with (optional, off-by-default) LDAP support.

I removed the --with-configdir to allow configs to be tucked in /etc/sasl2 along with the default location ($plugindir). This is necessary to allow configuring cyrus-sasl's behavior for some apps. For instance, I configure postfix's sasl2 with :

environment.etc."sasl2/smtpd.conf".text = ''
pwcheck_method: saslauthd
mech_list: PLAIN LOGIN
'';
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@roblabla
Copy link
Contributor Author

roblabla commented Jun 9, 2017

Bump ? The linux builds fail are due to cyrus-sasl causing a rebuild for lots of stuff, which causes the build to timeout. The Darwin fail, I'm not too sure what it is about.

error: i686-linux is required to build /nix/store/4kwi00qj6b9m14sqbd1gvp2s7p89c868-cyrus-sasl-2.5.10.drv, but I am a x86_64-darwin

@roblabla
Copy link
Contributor Author

Bump ? It's been more than a month and I haven't received any input on this PR. Anything I need to do to get this merged ?

Copy link
Member

@fpletz fpletz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, probably only few people are using these combinations of services and configurations. I've read the code and it looks fine to me but didn't test it.

Let's merge. 👍

@fpletz fpletz added this to the 17.09 milestone Jul 20, 2017
@fpletz fpletz added the 8.has: package (new) This PR adds a new package label Jul 20, 2017
@fpletz fpletz merged commit 00b6ac7 into NixOS:master Jul 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants