Use C++11 mutexes only (remove compat code) (#5922)

* Fix event LINT & remove default constructor/destructors * remove compat code & modernize autolock header
minetest · Jun 6, 2017 · d4c0f91 · d4c0f91
1 parent 8bdde45
commit d4c0f91
Show file tree

Hide file tree

Showing 36 changed files with 59 additions and 363 deletions.
diff --git a/src/ban.h b/src/ban.h
@@ -22,10 +22,10 @@ with this program; if not, write to the Free Software Foundation, Inc.,
 
 #include "util/string.h"
 #include "threading/thread.h"
-#include "threading/mutex.h"
 #include "exceptions.h"
 #include <map>
 #include <string>
+#include <mutex>
 
 class BanManager
 {
@@ -43,7 +43,7 @@ class BanManager
 	bool isModified();
 
 private:
-	Mutex m_mutex;
+	std::mutex m_mutex;
 	std::string m_banfilepath;
 	StringMap m_ips;
 	bool m_modified;

diff --git a/src/client.h b/src/client.h
@@ -23,7 +23,6 @@ with this program; if not, write to the Free Software Foundation, Inc.,
 #include "network/connection.h"
 #include "clientenvironment.h"
 #include "irrlichttypes_extrabloated.h"
-#include "threading/mutex.h"
 #include <ostream>
 #include <map>
 #include <set>

diff --git a/src/client/clientlauncher.cpp b/src/client/clientlauncher.cpp
@@ -657,7 +657,7 @@ void ClientLauncher::speed_tests()
 		infostream << "Around 5000/ms should do well here." << std::endl;
 		TimeTaker timer("Testing mutex speed");
 
-		Mutex m;
+		std::mutex m;
 		u32 n = 0;
 		u32 i = 0;
 		do {

diff --git a/src/client/tile.cpp b/src/client/tile.cpp
@@ -417,7 +417,7 @@ class TextureSource : public IWritableTextureSource
 	// Maps a texture name to an index in the former.
 	std::map<std::string, u32> m_name_to_id;
 	// The two former containers are behind this mutex
-	Mutex m_textureinfo_cache_mutex;
+	std::mutex m_textureinfo_cache_mutex;
 
 	// Queued texture fetches (to be processed by the main thread)
 	RequestQueue<std::string, u32, u8, u8> m_get_texture_queue;

diff --git a/src/clientiface.h b/src/clientiface.h
@@ -23,13 +23,13 @@ with this program; if not, write to the Free Software Foundation, Inc.,
 
 #include "constants.h"
 #include "serialization.h"             // for SER_FMT_VER_INVALID
-#include "threading/mutex.h"
 #include "network/networkpacket.h"
 #include "porting.h"
 
 #include <list>
 #include <vector>
 #include <set>
+#include <mutex>
 
 class MapBlock;
 class ServerEnvironment;
@@ -508,14 +508,14 @@ class ClientInterface {
 
 	// Connection
 	con::Connection* m_con;
-	Mutex m_clients_mutex;
+	std::mutex m_clients_mutex;
 	// Connected clients (behind the con mutex)
 	RemoteClientMap m_clients;
 	std::vector<std::string> m_clients_names; //for announcing masterserver
 
 	// Environment
 	ServerEnvironment *m_env;
-	Mutex m_env_mutex;
+	std::mutex m_env_mutex;
 
 	float m_print_info_timer;
 

diff --git a/src/debug.cpp b/src/debug.cpp
@@ -27,7 +27,6 @@ with this program; if not, write to the Free Software Foundation, Inc.,
 #include <cstring>
 #include <map>
 #include <sstream>
-#include "threading/mutex.h"
 #include "threading/mutex_auto_lock.h"
 #include "config.h"
 
@@ -152,7 +151,7 @@ void DebugStack::print(std::ostream &os, bool everything)
 // pthread_t, but it isn't too important since none of our supported platforms
 // implement pthread_t as a non-ordinal type.
 std::map<threadid_t, DebugStack*> g_debug_stacks;
-Mutex g_debug_stacks_mutex;
+std::mutex g_debug_stacks_mutex;
 
 void debug_stacks_init()
 {

diff --git a/src/emerge.h b/src/emerge.h
@@ -21,6 +21,7 @@ with this program; if not, write to the Free Software Foundation, Inc.,
 #define EMERGE_HEADER
 
 #include <map>
+#include <mutex>
 #include "irr_v3d.h"
 #include "util/container.h"
 #include "mapgen.h" // for MapgenParams
@@ -155,7 +156,7 @@ class EmergeManager {
 	std::vector<EmergeThread *> m_threads;
 	bool m_threads_active;
 
-	Mutex m_queue_mutex;
+	std::mutex m_queue_mutex;
 	std::map<v3s16, BlockEmergeData> m_blocks_enqueued;
 	std::unordered_map<u16, u16> m_peer_queue_count;
 

diff --git a/src/environment.h b/src/environment.h
@@ -34,10 +34,10 @@ with this program; if not, write to the Free Software Foundation, Inc.,
 #include <queue>
 #include <map>
 #include <atomic>
+#include <mutex>
 #include "irr_v3d.h"
 #include "activeobject.h"
 #include "util/numeric.h"
-#include "threading/mutex.h"
 #include "network/networkprotocol.h" // for AccessDeniedCode
 
 class IGameDef;
@@ -120,7 +120,7 @@ class Environment
 	IGameDef *m_gamedef;
 
 private:
-	Mutex m_time_lock;
+	std::mutex m_time_lock;
 
 	DISABLE_CLASS_COPY(Environment);
 };

diff --git a/src/face_position_cache.cpp b/src/face_position_cache.cpp
@@ -22,7 +22,7 @@ with this program; if not, write to the Free Software Foundation, Inc.,
 
 
 std::unordered_map<u16, std::vector<v3s16>> FacePositionCache::cache;
-Mutex FacePositionCache::cache_mutex;
+std::mutex FacePositionCache::cache_mutex;
 
 // Calculate the borders of a "d-radius" cube
 const std::vector<v3s16> &FacePositionCache::getFacePositions(u16 d)

diff --git a/src/face_position_cache.h b/src/face_position_cache.h
@@ -21,11 +21,11 @@ with this program; if not, write to the Free Software Foundation, Inc.,
 #define FACE_POSITION_CACHE_HEADER
 
 #include "irr_v3d.h"
-#include "threading/mutex.h"
 
 #include <map>
 #include <vector>
 #include <unordered_map>
+#include <mutex>
 
 /*
  * This class permits caching getFacePosition call results.
@@ -38,7 +38,7 @@ class FacePositionCache {
 private:
 	static const std::vector<v3s16> &generateFacePosition(u16 d);
 	static std::unordered_map<u16, std::vector<v3s16>> cache;
-	static Mutex cache_mutex;
+	static std::mutex cache_mutex;
 };
 
 #endif
diff --git a/src/httpfetch.cpp b/src/httpfetch.cpp
@@ -25,6 +25,7 @@ with this program; if not, write to the Free Software Foundation, Inc.,
 #include <list>
 #include <map>
 #include <errno.h>
+#include <mutex>
 #include "threading/event.h"
 #include "config.h"
 #include "exceptions.h"
@@ -36,7 +37,7 @@ with this program; if not, write to the Free Software Foundation, Inc.,
 #include "settings.h"
 #include "noise.h"
 
-Mutex g_httpfetch_mutex;
+std::mutex g_httpfetch_mutex;
 std::map<unsigned long, std::queue<HTTPFetchResult> > g_httpfetch_results;
 PcgRandom g_callerid_randomness;
 

diff --git a/src/log.h b/src/log.h
@@ -24,6 +24,7 @@ with this program; if not, write to the Free Software Foundation, Inc.,
 #include <queue>
 #include <string>
 #include <fstream>
+#include <mutex>
 #include "threads.h"
 #include "irrlichttypes.h"
 
@@ -79,7 +80,7 @@ class Logger {
 	// Works on all known architectures (x86, ARM, MIPS).
 	volatile bool m_silenced_levels[LL_MAX];
 	std::map<threadid_t, std::string> m_thread_names;
-	mutable Mutex m_mutex;
+	mutable std::mutex m_mutex;
 	bool m_trace_enabled;
 };
 

diff --git a/src/mesh_generator_thread.h b/src/mesh_generator_thread.h
@@ -20,6 +20,7 @@ with this program; if not, write to the Free Software Foundation, Inc.,
 #ifndef MESH_GENERATOR_THREAD_HEADER
 #define MESH_GENERATOR_THREAD_HEADER
 
+#include <mutex>
 #include "mapblock_mesh.h"
 #include "threading/mutex_auto_lock.h"
 #include "util/thread.h"
@@ -83,7 +84,7 @@ class MeshUpdateQueue
 	std::vector<QueuedMeshUpdate *> m_queue;
 	std::set<v3s16> m_urgents;
 	std::map<v3s16, CachedMapBlockData *> m_cache;
-	Mutex m_mutex;
+	std::mutex m_mutex;
 
 	// TODO: Add callback to update these when g_settings changes
 	bool m_cache_enable_shaders;

diff --git a/src/minimap.h b/src/minimap.h
@@ -23,7 +23,6 @@ with this program; if not, write to the Free Software Foundation, Inc.,
 #include "irrlichttypes_extrabloated.h"
 #include "client.h"
 #include "voxel.h"
-#include "threading/mutex.h"
 #include "threading/semaphore.h"
 #include <map>
 #include <string>
@@ -112,7 +111,7 @@ class MinimapUpdateThread : public UpdateThread {
 	virtual void doUpdate();
 
 private:
-	Mutex m_queue_mutex;
+	std::mutex m_queue_mutex;
 	std::deque<QueuedMinimapUpdate> m_update_queue;
 	std::map<v3s16, MinimapMapblock *> m_blocks_cache;
 };
@@ -161,7 +160,7 @@ class Minimap {
 	bool m_enable_shaders;
 	u16 m_surface_mode_scan_height;
 	f32 m_angle;
-	Mutex m_mutex;
+	std::mutex m_mutex;
 	std::list<v2f> m_active_markers;
 };
 

diff --git a/src/network/connection.cpp b/src/network/connection.cpp
@@ -42,7 +42,7 @@ namespace con
 #undef DEBUG_CONNECTION_KBPS
 #else
 /* this mutex is used to achieve log message consistency */
-Mutex log_message_mutex;
+std::mutex log_message_mutex;
 #define LOG(a)                                                                 \
 	{                                                                          \
 	MutexAutoLock loglock(log_message_mutex);                                 \

diff --git a/src/network/connection.h b/src/network/connection.h
@@ -349,7 +349,7 @@ class ReliablePacketBuffer
 
 	u16 m_oldest_non_answered_ack;
 
-	Mutex m_list_mutex;
+	std::mutex m_list_mutex;
 };
 
 /*
@@ -372,7 +372,7 @@ class IncomingSplitBuffer
 	// Key is seqnum
 	std::map<u16, IncomingSplitPacket*> m_buf;
 
-	Mutex m_map_mutex;
+	std::mutex m_map_mutex;
 };
 
 struct OutgoingPacket
@@ -544,7 +544,7 @@ class Channel
 
 	void setWindowSize(unsigned int size) { window_size = size; };
 private:
-	Mutex m_internal_mutex;
+	std::mutex m_internal_mutex;
 	int window_size;
 
 	u16 next_incoming_seqnum;
@@ -738,7 +738,7 @@ class Peer {
 		bool IncUseCount();
 		void DecUseCount();
 
-		Mutex m_exclusive_access_mutex;
+		std::mutex m_exclusive_access_mutex;
 
 		bool m_pending_deletion;
 
@@ -1064,12 +1064,12 @@ class Connection
 
 	std::map<u16, Peer*> m_peers;
 	std::list<u16> m_peer_ids;
-	Mutex m_peers_mutex;
+	std::mutex m_peers_mutex;
 
 	ConnectionSendThread m_sendThread;
 	ConnectionReceiveThread m_receiveThread;
 
-	Mutex m_info_mutex;
+	std::mutex m_info_mutex;
 
 	// Backwards compatibility
 	PeerHandler *m_bc_peerhandler;

diff --git a/src/particles.h b/src/particles.h
@@ -213,8 +213,8 @@ friend class ParticleSpawner;
 	std::map<u32, ParticleSpawner*> m_particle_spawners;
 
 	ClientEnvironment* m_env;
-	Mutex m_particle_list_lock;
-	Mutex m_spawner_list_lock;
+	std::mutex m_particle_list_lock;
+	std::mutex m_spawner_list_lock;
 };
 
 #endif
diff --git a/src/player.h b/src/player.h
@@ -22,8 +22,8 @@ with this program; if not, write to the Free Software Foundation, Inc.,
 
 #include "irrlichttypes_bloated.h"
 #include "inventory.h"
-#include "threading/mutex.h"
 #include <list>
+#include <mutex>
 
 #define PLAYERNAME_SIZE 20
 
@@ -186,7 +186,7 @@ class Player
 	// Protect some critical areas
 	// hud for example can be modified by EmergeThread
 	// and ServerThread
-	Mutex m_mutex;
+	std::mutex m_mutex;
 };
 
 #endif

diff --git a/src/profiler.h b/src/profiler.h
@@ -24,7 +24,6 @@ with this program; if not, write to the Free Software Foundation, Inc.,
 #include <string>
 #include <map>
 
-#include "threading/mutex.h"
 #include "threading/mutex_auto_lock.h"
 #include "util/timetaker.h"
 #include "util/numeric.h"      // paging()
@@ -177,7 +176,7 @@ class Profiler
 	}
 
 private:
-	Mutex m_mutex;
+	std::mutex m_mutex;
 	std::map<std::string, float> m_data;
 	std::map<std::string, int> m_avgcounts;
 	std::map<std::string, float> m_graphvalues;

diff --git a/src/quicktune.cpp b/src/quicktune.cpp
@@ -18,7 +18,6 @@ with this program; if not, write to the Free Software Foundation, Inc.,
 */
 
 #include "quicktune.h"
-#include "threading/mutex.h"
 #include "threading/mutex_auto_lock.h"
 #include "util/string.h"
 
@@ -49,12 +48,12 @@ void QuicktuneValue::relativeAdd(float amount)
 
 static std::map<std::string, QuicktuneValue> g_values;
 static std::vector<std::string> g_names;
-Mutex *g_mutex = NULL;
+std::mutex *g_mutex = NULL;
 
 static void makeMutex()
 {
 	if(!g_mutex){
-		g_mutex = new Mutex();
+		g_mutex = new std::mutex();
 	}
 }
 

diff --git a/src/script/cpp_api/s_async.h b/src/script/cpp_api/s_async.h
@@ -25,7 +25,6 @@ with this program; if not, write to the Free Software Foundation, Inc.,
 #include <map>
 
 #include "threading/thread.h"
-#include "threading/mutex.h"
 #include "threading/semaphore.h"
 #include "debug.h"
 #include "lua.h"
@@ -147,13 +146,13 @@ class AsyncEngine {
 	unsigned int jobIdCounter;
 
 	// Mutex to protect job queue
-	Mutex jobQueueMutex;
+	std::mutex jobQueueMutex;
 
 	// Job queue
 	std::deque<LuaJobInfo> jobQueue;
 
 	// Mutex to protect result queue
-	Mutex resultQueueMutex;
+	std::mutex resultQueueMutex;
 	// Result queue
 	std::deque<LuaJobInfo> resultQueue;