Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Docs to API 6.0.0 #607

Merged
merged 8 commits into from Jun 11, 2017
Merged

Update Docs to API 6.0.0 #607

merged 8 commits into from Jun 11, 2017

Conversation

Inscrutable
Copy link
Member

@Inscrutable Inscrutable commented Jun 6, 2017

Resolves #601
Pages to update:

  • gradle
  • maven
  • sponge.conf
  • mixins
  • arguments
  • debugging

@Inscrutable Inscrutable added the high priority This needs to be fixed ASAP label Jun 6, 2017
@Inscrutable Inscrutable self-assigned this Jun 6, 2017
@Inscrutable Inscrutable added this to the v6.0.0 milestone Jun 6, 2017
@johnfg2610
Copy link

https://cdn.rawgit.com/Spongy/SpongeDocs-PRs/9f278a7/plugin/project/index.html
version also needs updating to version 6.0.0 stable and version 7.0.0-SNAPSHOT snapshot

@@ -17,7 +17,7 @@ is available at the `Mixin Wiki <https://github.com/SpongePowered/Mixin/wiki/>`_
mixins themselves are actually discussed.*

If you're looking to get started writing mixins, we also strongly recommend carefully examining all of the examples in
the `SpongeForge repository <https://github.com/SpongePowered/SpongeCommon/tree/stable-5/src/example/java/org/spongepowered>`__ which
the `SpongeForge repository <https://github.com/SpongePowered/SpongeCommon/tree/stable-6/src/example/java/org/spongepowered>`__ which
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This actually links to the SpongeCommon repository now, so maybe change the piece beforehand?

@@ -232,7 +243,7 @@ This config was generated using SpongeForge build 2022 (with Forge 2202), Sponge
# # If you need help with the configuration or have any questions related to Sponge,
# # join us at the IRC or drop by our forums and leave a post.
#
# # IRC: #sponge @ irc.esper.net ( https://webchat.esper.net/?channel=sponge )
# # IRC: #sponge @ irc.esper.net ( http://webchat.esper.net/?channel=sponge )
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should point to https

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't we just have it link to the IRC/chat page on SpongeHome to keep them in the Sponge website ecosystem.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to get this PR done ASAP. If more changes are needed in SpongeCommon, please get it done, or throw the lever and the docs can catch up later.

@Inscrutable Inscrutable merged commit 84fd53b into stable Jun 11, 2017
@Inscrutable Inscrutable deleted the Update-to-API6 branch July 22, 2017 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high priority This needs to be fixed ASAP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants