-
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Docs to API 6.0.0 #607
Conversation
https://cdn.rawgit.com/Spongy/SpongeDocs-PRs/9f278a7/plugin/project/index.html |
@@ -17,7 +17,7 @@ is available at the `Mixin Wiki <https://github.com/SpongePowered/Mixin/wiki/>`_ | |||
mixins themselves are actually discussed.* | |||
|
|||
If you're looking to get started writing mixins, we also strongly recommend carefully examining all of the examples in | |||
the `SpongeForge repository <https://github.com/SpongePowered/SpongeCommon/tree/stable-5/src/example/java/org/spongepowered>`__ which | |||
the `SpongeForge repository <https://github.com/SpongePowered/SpongeCommon/tree/stable-6/src/example/java/org/spongepowered>`__ which |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This actually links to the SpongeCommon repository now, so maybe change the piece beforehand?
@@ -232,7 +243,7 @@ This config was generated using SpongeForge build 2022 (with Forge 2202), Sponge | |||
# # If you need help with the configuration or have any questions related to Sponge, | |||
# # join us at the IRC or drop by our forums and leave a post. | |||
# | |||
# # IRC: #sponge @ irc.esper.net ( https://webchat.esper.net/?channel=sponge ) | |||
# # IRC: #sponge @ irc.esper.net ( http://webchat.esper.net/?channel=sponge ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should point to https
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why don't we just have it link to the IRC/chat page on SpongeHome to keep them in the Sponge website ecosystem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to get this PR done ASAP. If more changes are needed in SpongeCommon, please get it done, or throw the lever and the docs can catch up later.
Resolves #601
Pages to update: