Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

idea.idea-ultimate: 2017.1.2 -> 2017.1.3 #26425

Merged
merged 1 commit into from
Jun 8, 2017
Merged

idea.idea-ultimate: 2017.1.2 -> 2017.1.3 #26425

merged 1 commit into from
Jun 8, 2017

Conversation

uskudnik
Copy link
Contributor

@uskudnik uskudnik commented Jun 6, 2017 •
edited

Motivation for this change

Jetbrains released a new minor version.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Note: First pull request on NixOS/nixpkgs, if I missed something please let me know. I tested the package by nix-build -A idea.idea-ultimate, tested ./result/bin/idea-ultimate and later installed it into my profile with nix-env -f . -iA idea.idea-ultimate.

@uskudnik uskudnik changed the title jetbrains.idea-ultimate: 2017.1.2 -> 2017.1.3 idea.idea-ultimate: 2017.1.2 -> 2017.1.3 Jun 6, 2017
@phile314-fh
Copy link
Contributor

I tried out your PR, but I get a different hash:

output path ‘/nix/store/zy23qvggw23g2q46ikpcgv8zm73jsrn6-ideaIU-2017.1.3-no-jdk.tar.gz’
has sha256 hash ‘1gl62zrs3yxakgwbm29bv9z68jgy5ixc28zcagydx2h4j2b1fb19’
when            ‘1236vq56fjx30fnkqzjdz56g8hapld1lzrcd7c7fkr8wpzgg5nzg’ was expected

@uskudnik uskudnik force-pushed the idea-ultimate-minor-2017.1.3 branch from 5b5e545 to df8837c Compare June 7, 2017 15:18
@uskudnik
Copy link
Contributor Author

uskudnik commented Jun 7, 2017

@phile314 Ah, my bad - I was first using non-base32 hash and when I switched to base32 I forgot to add --flat argument (and didn't re-run entire testing process at that point).

Amended my commit and forced pushed, should be good now.

P.S. I'm rather surprised that travis didn't detect this? Is that desired behavior? Should I open a new issue about it?

$ nix-hash --type sha256 --base32 /nix/store/zy23qvggw23g2q46ikpcgv8zm73jsrn6-ideaIU-2017.1.3-no-jdk.tar.gz
1236vq56fjx30fnkqzjdz56g8hapld1lzrcd7c7fkr8wpzgg5nzg

$ nix-hash --type sha256 --base32 /nix/store/zy23qvggw23g2q46ikpcgv8zm73jsrn6-ideaIU-2017.1.3-no-jdk.tar.gz --flat
1gl62zrs3yxakgwbm29bv9z68jgy5ixc28zcagydx2h4j2b1fb19

@phile314-fh
Copy link
Contributor

Works for me now 👍

I suspect Travis didn't really build it as Idea Ultimate is marked as unfree because it is not open source. If so, the Travis report is highly misleading...

phile314-fh
phile314-fh approved these changes Jun 7, 2017
View reviewed changes
Copy link
Contributor

@phile314-fh phile314-fh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with some example projects and everything worked fine.

@Mic92 Mic92 merged commit 340b314 into NixOS:master Jun 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phile314-fh phile314-fh phile314-fh approved these changes

Assignees
No one assigned
Labels
12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@uskudnik @phile314-fh @Mic92 @Janik-Haag