-
-
Notifications
You must be signed in to change notification settings - Fork 15.5k
gdal: Add hdf4 support #26039
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gdal: Add hdf4 support #26039
Conversation
@knedlsepp, thanks for your PR! By analyzing the history of the files in this pull request, we identified @vbgl, @Hodapp87 and @MarcWeber to be potential reviewers. |
d4e0377
to
ddc340d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps its worth to separate hdf4 into multiple outputs.
@@ -41,6 +46,7 @@ composableDerivation.composableDerivation {} (fixed: rec { | |||
"--with-python" # optional | |||
"--with-static-proj4=${proj}" # optional | |||
"--with-geos=${geos}/bin/geos-config"# optional | |||
"--with-hdf4=${hdf4}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add the note that this is optional
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. I'll also look into the multiple outputs issue.
1abc953
to
f364a4c
Compare
@FRidh I split hdf4 up into bin/dev/out. I had to manually specify |
@FRidh: Would you consider merging? |
Some of the errors that I could find in the log:
I think you might want to undo the multiple outputs. I tried to use them with hdf5 as well after I suggested it to you, but it didn't work out at all. |
Okay, so I tried myself without multiple outputs, and I still get the errors. |
Do you have a NixOS machine with sandbox that you could test on? |
Oh. Didn't expect that the NixOS build would fail. I'll spin up a VM and see what's the deal. I suppose it will be the same problem as on the mac, where I need to set $DYLD_LIBRARY_PATH for the checkPhase. The test-binaries don't seem to know that they should look for the library in the build directory. |
Adding an "export LD_LIBRARY_PATH=$(pwd)/bin" seemed to help. |
f364a4c
to
7b25d31
Compare
@FRidh: Should work by now. |
Motivation for this change
I want to add hdf4 support to the gdal library.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandbox
innix.conf
on non-NixOS)
nix-shell -p nox --run "nox-review wip"
./result/bin/
)