Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appveyor: Add ActiveState Perl build #206

Merged
merged 7 commits into from May 22, 2018
Merged

Conversation

zmughal
Copy link
Member

@zmughal zmughal commented May 23, 2017

No description provided.

@zmughal zmughal requested review from devel-chm and mohawk2 May 23, 2017 19:47
Copy link
Member

@mohawk2 mohawk2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but I would most like Makefile.PL tolerate not have Devel::CheckLib installed so cpanm could generate then read its deps.

@coveralls
Copy link

coveralls commented May 23, 2017

Coverage Status

Coverage remained the same at 52.615% when pulling 4e6956c on appveyor-activestate-perl into f5457e4 on master.

@wchristian wchristian closed this Mar 1, 2018
@wchristian wchristian deleted the appveyor-activestate-perl branch March 1, 2018 20:35
@wchristian wchristian restored the appveyor-activestate-perl branch March 1, 2018 20:50
@wchristian wchristian deleted the appveyor-activestate-perl branch March 1, 2018 23:00
@wchristian wchristian restored the appveyor-activestate-perl branch March 1, 2018 23:15
@mohawk2 mohawk2 reopened this Mar 2, 2018
@wchristian wchristian closed this Apr 2, 2018
@wchristian wchristian deleted the appveyor-activestate-perl branch April 2, 2018 01:05
@wchristian wchristian restored the appveyor-activestate-perl branch April 2, 2018 01:10
@wchristian wchristian deleted the appveyor-activestate-perl branch April 4, 2018 13:45
@wchristian wchristian restored the appveyor-activestate-perl branch April 4, 2018 13:50
@wchristian wchristian deleted the appveyor-activestate-perl branch April 4, 2018 16:25
@wchristian wchristian restored the appveyor-activestate-perl branch April 4, 2018 16:32
@wchristian wchristian deleted the appveyor-activestate-perl branch April 4, 2018 19:56
@wchristian wchristian restored the appveyor-activestate-perl branch April 4, 2018 20:11
@wchristian wchristian deleted the appveyor-activestate-perl branch April 6, 2018 11:50
@wchristian wchristian restored the appveyor-activestate-perl branch April 6, 2018 11:56
@wchristian wchristian deleted the appveyor-activestate-perl branch April 6, 2018 12:51
@wchristian wchristian restored the appveyor-activestate-perl branch April 6, 2018 12:56
@wchristian wchristian deleted the appveyor-activestate-perl branch April 9, 2018 14:31
@wchristian wchristian restored the appveyor-activestate-perl branch April 9, 2018 14:43
@wchristian wchristian deleted the appveyor-activestate-perl branch April 24, 2018 08:22
@wchristian wchristian restored the appveyor-activestate-perl branch April 24, 2018 08:25
@wchristian wchristian deleted the appveyor-activestate-perl branch May 4, 2018 02:40
@wchristian wchristian restored the appveyor-activestate-perl branch May 4, 2018 02:45
@mohawk2 mohawk2 reopened this May 7, 2018
@mohawk2 mohawk2 force-pushed the appveyor-activestate-perl branch from e061c9b to 4139a18 Compare May 10, 2018 20:09
@mohawk2
Copy link
Member

mohawk2 commented May 10, 2018

I just force-pushed this, rebased on current master, zapping the adding of Devel::CheckLib which is now not needed.

@mohawk2
Copy link
Member

mohawk2 commented May 10, 2018

This is now showing success: https://ci.appveyor.com/project/zmughal/pdl/build/1.0.635

@mohawk2
Copy link
Member

mohawk2 commented May 16, 2018

@zmughal Could you check my updated version of this? It now passes. If you're happy, please merge :-)

@mohawk2
Copy link
Member

mohawk2 commented May 22, 2018

Since this is @zmughal 's excellent work, just tweaked a bit by me, I consider this to be reviewed so will merge.

@mohawk2 mohawk2 merged commit 70229ad into master May 22, 2018
@mohawk2 mohawk2 deleted the appveyor-activestate-perl branch May 22, 2018 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants