Skip to content

openpa: init -> 1.0.4 #26033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2017
Merged

openpa: init -> 1.0.4 #26033

merged 1 commit into from
Jun 27, 2017

Conversation

leenaars
Copy link
Contributor

@leenaars leenaars commented May 23, 2017

Motivation for this change

High performance scientific library which also happens to be a dependency for another project I'm packaging.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

Unverified

The committer email address is not verified.
@joachifm
Copy link
Contributor

joachifm commented Jun 5, 2017

How do you determine the absence of implicit dependencies without sandboxing?

@joachifm joachifm added the 8.has: package (new) This PR adds a new package label Jun 16, 2017
@leenaars
Copy link
Contributor Author

@joachifm: You are right, this is an assumption. I did read the wiki pages, which said that "Most users of OPA will only ever need to deal with one file". Given that it is known to be portable "on as many platforms as [the developers] reasonably can" support, ranging from supercomputing platforms to Windows (but no autobuild system for that available yet), I thought it would be more or less safe. I must confess I have not used the sandbox feature yet ...

@joachifm joachifm merged commit 10126e1 into NixOS:master Jun 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants