Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle nil buffer in Zlib::GzipReader#readpartial #4673

Merged
merged 2 commits into from
Jun 22, 2017
Merged

Handle nil buffer in Zlib::GzipReader#readpartial #4673

merged 2 commits into from
Jun 22, 2017
+18 −1

Conversation

haines
Copy link
Contributor

@haines haines commented Jun 16, 2017

In MRI it's ok to explicitly pass a nil buffer to #readpartial. However, JRuby currently throws a TypeError.

This adds a nil-check to bring JRuby in line with MRI's behaviour.

@kares kares added this to the JRuby 9.2.0.0 milestone Jun 22, 2017
@kares
Copy link
Member

kares commented Jun 22, 2017

good catch, thanks.

@kares kares merged commit eef3f72 into jruby:master Jun 22, 2017
@haines haines deleted the gzip_reader_readpartial branch June 22, 2017 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
JRuby 9.2.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@haines @kares