bind: add cfg options for listen-on and listen-on-v6. #26430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds configuration options for the bind package so that the interfaces that bind listens on can be configured rather than just hardcoded as any. The default values preserve the old behavior to be backwards compatible.
peterhoeg
reviewed
Jun 9, 2017
| @@ -96,6 +96,20 @@ in | |||
| "; | |||
| }; | |||
|
|
|||
| listenOn = mkOption { | |||
| default = ["any"]; | |||
There was a problem hiding this comment.
We need a type in here as well as below.
|
Added types for the new options in e13af4e. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds configuration options for the bind package so that the interfaces that bind listens on can be configured rather than just hardcoded as any. The default values preserve the old behavior to be backwards compatible.
Motivation for this change
The bind configuration is always listening on "any" interface. This change allows configuration of which interfaces to listen on. This is useful to listen on only certain networks.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)