Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support of std::array to hpx::util::tuple_size and tuple_element #2685

Merged
merged 1 commit into from Jun 13, 2017
Merged

Add support of std::array to hpx::util::tuple_size and tuple_element #2685

merged 1 commit into from Jun 13, 2017

Conversation

Naios
Copy link
Contributor

@Naios Naios commented Jun 6, 2017 •
edited

Didn't run the test suite on it yet, let's see how it goes.

@Naios
Copy link
Contributor Author

Naios commented Jun 6, 2017

I was asking myself whether we still need HPX_HAVE_CXX11_STD_ARRAY, since it should be theoretically supported on all required platforms.

@hkaiser hkaiser added this to the 1.1.0 milestone Jun 6, 2017
@K-ballo
Copy link
Member

K-ballo commented Jun 6, 2017

I'd suggest we mark support for std::array as required in cmake (which will in turn no longer emit the HAVE macro), and drop support for boost::array in the process.

@Naios
Copy link
Contributor Author

Naios commented Jun 7, 2017

@K-ballo do you prefer the changes you mentioned above over this PR, or can those be applied after this PR was merged?

@Naios Naios mentioned this pull request Jun 7, 2017
Merged
@K-ballo
Copy link
Member

K-ballo commented Jun 7, 2017

@K-ballo do you prefer the changes you mentioned above over this PR, or can those be applied after this PR was merged?

@Naios I don't particularly care in which way the changes make it into master, as long as they do.

@Naios
Copy link
Contributor Author

Naios commented Jun 7, 2017

@K-ballo I will take care about this later during my GSoC project, it would be good, if we could merge this PR meanwhile, because it's required by #2687.

hkaiser
hkaiser approved these changes Jun 7, 2017
View reviewed changes
Copy link
Member

@hkaiser hkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@hkaiser hkaiser merged commit 0025fba into STEllAR-GROUP:master Jun 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkaiser hkaiser hkaiser approved these changes

Assignees
No one assigned
Labels
category: core type: compatibility issue type: enhancement
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Naios @K-ballo @hkaiser