llvm_4: Fix debugVersion #26429
Merged
llvm_4: Fix debugVersion #26429
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously failed on installation phase when `substituteInPlace` could not find the cmake exports file.
LnL7
added
the
1.severity: mass-darwin-rebuild
bennofs
added
6.topic: darwin
|
@LnL7 this shouldn't lead to a mass rebuild, as the derivation is the same as long as /cc @NixOS/darwin-maintainers for testing |
|
👍 |
|
@bennofs Oh my bad, I must have glanced over the changes to quickly. |
LnL7
approved these changes
Jul 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
LLVM 4.0 in debug mode previously failed on installation phase
when
substituteInPlacecould not find the cmake exports file.Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)CC maintainers: @lovek323 @viric @dtzWill