generators.toPretty and traceValSeqN #26433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`toPretty` implements a pretty printer for nix values.
Strict trace functions that only go down to a specified depth. Handy to get a better picture and prevent infinite recursions.
|
@Profpatsch, thanks for your PR! By analyzing the history of the files in this pull request, we identified @MarcWeber, @edolstra and @zagy to be potential reviewers. |
With `builtins.functionArgs` we can get some information if the first argument is an attrset and whether the contained fields have default values. Encode that into the pretty-printed lambda.
|
IMHO it would be better to do this in Nix itself (e.g. by extending |
Why would nix-repl not be able to use nix functions to determine pretty printing? |
|
I will just merge now, since nothing else depends on it. If need be, we can integrate it into nix later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First introduces a pretty printing generator, then uses that to create a debugging function that only goes
nlevels deep. See commit messages.