Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BE-4 engine updates & fixes #1652

Merged
merged 4 commits into from Jun 22, 2017
Merged

BE-4 engine updates & fixes #1652

merged 4 commits into from Jun 22, 2017

Conversation

PhineasFreak
Copy link
Contributor

@PhineasFreak PhineasFreak commented May 27, 2017

Change Log:

  • Add some basic info and web sources to the global engine config.
  • Add a default part module category.
  • Add some default engine module parameters.
  • Tweak the minimum and maximum thrust value to correspond to a rated VAC thrust of 550000 lbf.
  • Update the ASL and VAC Isp values (note 1).
  • Remove the requirement of a TEATEB resource for ignition.
  • Fix the size of the VSR 2 x BE-4 engine cluster (was too small).

Notes:

@SirKeplan SirKeplan self-requested a review May 27, 2017 14:05
@SirKeplan
Copy link
Member

couple quick notes.

550000 lbf is actually SL thrust

later found min thrust is 30%.

http://forum.nasaspaceflight.com/index.php?topic=10685.msg1665037#msg1665037

@PhineasFreak
Copy link
Contributor Author

PhineasFreak commented May 27, 2017

Time to bug fix the bug fix i guess!

@SirKeplan
Copy link
Member

Isp looks unrealistically high, are you going off of RPA's theoretical perf rather than estimated performance? Also i don't think even BO know it's real performance yet, until they do tests. maybe we should leave the Isp at spacelaunchreport's estimates.

The NSF forum link also says 5 degrees of gimbal, but that's on New Glenn, presumably Vulcan will have more as it's an Atlas successor and might take uneven SRB arrangements.

I think everything else is ok.

@SirKeplan SirKeplan removed their request for review May 31, 2017 00:33
@PhineasFreak
Copy link
Contributor Author

I went by the facts that it is a Methalox engine and one of the "requirements" for Vulcan is to have at least, if not better, Isp figures than the RD-180. The VAC figure might stretch it a bit, is that one that you refer as unrealistic? BTW, i used the Altitude Peformance values (318.42 s ASL / 354.59 s VAC).

It is also difficult to get good estimates for the throat and exhaust areas. A measurement error of just 1 px translates into almost 0.0795 m (~7.95 cm) and that is why i used an expansion area ratio of 25 (as quoted by many articles and posts). Dropping the freeze value of the area ratio at 1 instead of 3 gets a more meager 309 s ASL / 345 s VAC.

@SirKeplan
Copy link
Member

SirKeplan commented May 31, 2017

@PhineasFreak well i think they are both unrealistic, though VAC figure is more so i guess. using your file (with a ratio of 3) i get this http://i.imgur.com/E4Pkvvr.png, (305.46 Sl / 341.63 Vac) your RPA was probably giving theoretical(ideal) performance in the altitude tab rather than estimated performance for some reason.

these numbers are only a little higher than spacelaunchreport's estimate, probably reasonable.

@PhineasFreak
Copy link
Contributor Author

PhineasFreak commented May 31, 2017

@SirKeplan yes, my bad. I found out that i was looking at the wrong info after all...

So, freeze the values at 305/341?

@SirKeplan
Copy link
Member

@PhineasFreak Yes, that should be fine.

@PhineasFreak
Copy link
Contributor Author

PhineasFreak commented May 31, 2017

@SirKeplan apologies for "breaking" your current review with the new TF stuff...but i forgot to include them...

😟

@PhineasFreak
Copy link
Contributor Author

So, are we good here?

@SirKeplan SirKeplan merged commit 0aafd9c into KSP-RO:master Jun 22, 2017
@PhineasFreak PhineasFreak deleted the RO-BE4-Update branch June 23, 2017 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants