mkPythonDerivation: obey a dontWrapPythonPrograms attribute #26142
Conversation
This should allow a python derivation to disable possibly overzealous python program wrapping without having to override the whole fixupPhase
|
The two failures appear to be because of log limits exceeding again - it would be nice if some more people could do some local builds of this because I'm having trouble building current |
|
@risicle note that, if you want to limit wrapping to only |
|
Oh man. Perhaps this is best ignored then. It's a potentially useful feature, but adding a feature-with-no-users feels more like noise. |
|
I've pushed 45ac770 to master because I think it will come to use at some point. |
|
and also c10af9e so we don't need the other commit anymore. |
|
ok fair enough |
Motivation for this change
85a87f5 broke python packages not wanting all potential "programs" wrapped with
wrapPythonProgramsbut also not wanting to have to replace/disable the wholefixupPhase. Notably django.I propose borrowing a leaf out of
mkDerivation's book and makingmkPythonDerivationobey adontWrapPythonProgramsflag.This includes a followup commit adding the flag to django packages to fix them.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)