Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cc-wrapper: propagate outputs #26153

Closed
wants to merge 1 commit into from
Closed

cc-wrapper: propagate outputs #26153

wants to merge 1 commit into from
+11 −3

Conversation

LnL7
Copy link
Member

@LnL7 LnL7 commented May 27, 2017

Motivation for this change

This makes it easier to reference the other outputs of wrapped compilers, eg.

{ pkgs, ... }:
{
  environment.systemPackages = [ gcc.man ];
}
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@LnL7 LnL7 added the 1.severity: mass-rebuild This PR causes a large number of packages to rebuild label May 27, 2017
@LnL7 LnL7 mentioned this pull request May 27, 2017
Merged
7 tasks
@vcunat
Copy link
Member

vcunat commented Jun 1, 2017

This assumes the compiler itself is in .cc.out, but that seems OK, at least for now.

@LnL7
Copy link
Member Author

LnL7 commented Jun 1, 2017

I could change it to use the first output instead.

@vcunat
Copy link
Member

vcunat commented Jun 1, 2017

Yes, I think that would be better with the way we handle default outputs now. It would also mean that filter would be changed to simple tail :-)

@edolstra
Copy link
Member

edolstra commented Jun 2, 2017

What's wrong with saying gcc.cc.man? Propagating outputs seems ad hoc and potentially confusing to me.

@vcunat
Copy link
Member

vcunat commented Jun 2, 2017

I thought the main advantage would be that systemPackages = [ gcc ] will provide the man pages if you have that set up, and (in future) also nix-env.

@LnL7
Copy link
Member Author

LnL7 commented Jun 2, 2017

Yes, just convenience.

@LnL7
Copy link
Member Author

LnL7 commented Jun 23, 2017

Given things like #26756, this could have some unwanted side effects.

@LnL7 LnL7 closed this Jun 23, 2017
@LnL7 LnL7 deleted the cc-outputs branch June 23, 2017 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
1.severity: mass-rebuild This PR causes a large number of packages to rebuild
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LnL7 @vcunat @edolstra