libvmi: init at 3e4114 #26162
Merged
libvmi: init at 3e4114 #26162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
May 27, 2017
| sha256 = "0vbmrj0ij19i55afkqj64q7sgh0scpwk3c99qx6p6gn1qcy2wdss"; | ||
| }; | ||
|
|
||
| buildInputs = [ glib xen which yacc bison flex libtool autoconf automake pkgconfig libvirt ]; |
There was a problem hiding this comment.
- buildInputs = [ glib xen which yacc bison flex libtool autoconf automake pkgconfig libvirt ];
+ buildInputs = [ glib xen which libvirt ]; # probably which too.
+ nativeBuildInputs = [ yacc bison flex libtool autoconf automake pkgconfig ]; |
|
||
| stdenv.mkDerivation rec { | ||
| name = "libvirt-${version}"; | ||
| version = "20170527-${stdenv.lib.strings.substring 0 7 rev}"; |
There was a problem hiding this comment.
we prefer to have a numeric value at the end, to make it sortable for nix-env -u. See also https://nixos.org/nixpkgs/manual/#sec-package-naming
FRidh
reviewed
May 30, 2017
| nativeBuildInputs = [ yacc bison flex libtool autoconf automake pkgconfig ]; | ||
|
|
||
| preConfigure = '' | ||
| ./autogen.sh |
There was a problem hiding this comment.
Thanks for the tip, fixed.
Mic92
reviewed
Jun 11, 2017
| with stdenv.lib; | ||
|
|
||
| stdenv.mkDerivation rec { | ||
| name = "libvirt-${version}"; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)