Skip to content

dkimproxy: init at 1.4.1 #26147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 28, 2017
Merged

dkimproxy: init at 1.4.1 #26147

merged 5 commits into from
May 28, 2017

Conversation

Ekleog
Copy link
Member

@Ekleog Ekleog commented May 27, 2017

Motivation for this change

OpenSMTPD not supporting OpenDKIM but only dkimproxy (for the time being), dkimproxy may prove useful.

Note: I have just tested the executable appears to build at the moment, not yet that it works, not having yet a fully functional OpenSMTPD setup. The package builds on NixOS with sandboxing, and all executables appear to run without obvious errors. I'll come back after having finished setting up an OpenSMTPD using it if that's required for merging.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

description = "SMTP-proxy that signs and/or verifies emails";
homepage = http://dkimproxy.sourceforge.net/;
license = licenses.gpl2Plus;
maintainers = [ ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to maintain this package?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I'd have thought buildPerlPackages did more than just adding perl in buildInputs, thanks for the simplification!

As for maintaining, I can maintain it. Pushing a commit that adds me as maintainer right now. :)

@Ekleog
Copy link
Member Author

Ekleog commented May 28, 2017

It turns out buildPerlPackage was actually required: without it, dkim_responder.pl fails with the following error message:

Can't locate MIME/Entity.pm in @INC (you may need to install the MIME::Entity module) (@INC contains: /nix/store/vapgb6j9jydhklv1zas4a9syii6mwbf5-dkimproxy-1.4.1/lib /nix/store/vapgb6j9jydhklv1zas4a9syii6mwbf5-dkimproxy-1.4. /home/ekleog/.nix-profile/lib/perl5/site_perl /nix/var/nix/profiles/default/lib/perl5/site_perl /run/current-system/sw/lib/perl5/site_perl/5.24.1/x86_64-linux-thread-multi /run/current-system/sw/lib/perl5/site_perl/5.24.1 /run/current-system/sw/lib/perl5/site_perl /nix/store/fd7m7yxql9nx05arfcqnwfh7vdwcgvxb-perl-5.24.1/lib/perl5/site_perl/5.24.1/x86_64-linux-thread-multi /nix/store/fd7m7yxql9nx05arfcqnwfh7vdwcgvxb-perl-5.24.1/lib/perl5/site_perl/5.24.1 /nix/store/fd7m7yxql9nx05arfcqnwfh7vdwcgvxb-perl-5.24.1/lib/perl5/5.24.1/x86_64-linux-thread-multi /nix/store/fd7m7yxql9nx05arfcqnwfh7vdwcgvxb-perl-5.24.1/lib/perl5/5.24.1 .) at /home/ekleog/.nix-profile/bin/dkim_responder.pl line 26.
BEGIN failed--compilation aborted at /home/ekleog/.nix-profile/bin/dkim_responder.pl line 26.

As I don't really know the perl infrastructure in nixos (and not much more perl, actually), I don't know of any other way of fixing this than by going back to buildPerlPackage.

@Ekleog
Copy link
Member Author

Ekleog commented May 28, 2017

OK so it looks like I failed my test process and the issue is not the switch between mkDerivation and buildPerlPackage but rather an environment issue (running with env -i makes the failure appear).

I don't really know how I got to this, but will try pushing a corrected version as soon as possible.

@Ekleog
Copy link
Member Author

Ekleog commented May 28, 2017

Here it is, I guess my overriding the configurePhase removed the preConfigure from pkgs/development/perl-modules/generic/builder.sh; so here it is made "by hand".

Now dkim_responder.pl no longer fails when run under env -i.

@pSub pSub added the 8.has: package (new) This PR adds a new package label May 28, 2017
@Mic92 Mic92 merged commit 4a0c7d1 into NixOS:master May 28, 2017
@Mic92
Copy link
Member

Mic92 commented May 28, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants