Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: allow bgSupport for windowManagers as well #26156

Closed
wants to merge 2 commits into from
Closed

WIP: allow bgSupport for windowManagers as well #26156

wants to merge 2 commits into from

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented May 27, 2017 •
edited

Motivation for this change

see #25978

I'd like to have some configurable background for windowManagers as well.

This isn't mergable right now, here's a TODO list:

  • basic implementation for background-image support
  • test windowManagers
    • i3
    • XMonad
    • Awesome ⚠️ No support for backgrounds with feh
    • ...
  • allow directory as well (using feh --randomize for multiple backgrounds)
  • avoid code duplication (this is stolen from display-managers/default.nix, could be moved into a general function to avoid duplicated code)
  • beautify commit history
  • fix merge conflict
  • confirm that desktopManagers still work
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@Ma27, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nbp, @AndersonTorres and @edolstra to be potential reviewers.

@bennofs
Copy link
Contributor

bennofs commented May 28, 2017

Why do you need this? If you're running a window manager without a large desktop (like gnome or kde), it IMO still makes sense to at least have a custom desktop session for which you can then use the existing attribute (like https://github.com/bennofs/etc-nixos/blob/61a5014477176ce40bbb7f04cc3d7241a22199c0/conf/desktop.nix#L63-L92)

@Ma27
Copy link
Member Author

Ma27 commented May 29, 2017

@bennofs you're right actually. This was just a first idea I wanted to work on (and I always try to contribute such things back to NixOS to support the project), but your approach with a custom desktopManager seems fine as well.

If everybody is fine with this, I'll close this tonight...

@Ma27
Copy link
Member Author

Ma27 commented May 29, 2017

ok, closing for now

@Ma27 Ma27 closed this May 29, 2017
@Ma27 Ma27 deleted the 25978-refactor-bg-image-module branch May 29, 2017 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: work-in-progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Ma27 @mention-bot @bennofs @pSub