wine: reorganize packages #26152
wine: reorganize packages #26152
Conversation
|
@abbradar, thanks for your PR! By analyzing the history of the files in this pull request, we identified @michalrus and @joachifm to be potential reviewers. |
pkgs/top-level/all-packages.nix
Outdated
| }; | ||
|
|
||
| stable = base.override { wineRelease = "stable"; }; | ||
| snstable = base.override { wineRelease = "unstable"; }; |
| xmlSupport = true; | ||
| }; | ||
|
|
||
| full = base.override { |
There was a problem hiding this comment.
@Mic92 Hm, why not indeed since it's "full".
|
@Mic92 Fixed. |
|
Wait, I'm not sure |
|
generally looks good for me! |
|
Added WOW64 support to the full version for 64-bit systems and built them. |
| }); | ||
| wineStable = self.wine.override { wineRelease = "stable"; }; | ||
| wineUnstable = lowPrio (self.wine.override { wineRelease = "unstable"; }); |
There was a problem hiding this comment.
Maybe worth adding wineUnstable to pkgs/top-level/aliases.nix?
There was a problem hiding this comment.
@Mic92 Won't it then be built on Hydra? Since we want to stop building most of Wine packages now is the good time to do breaking changes.
There was a problem hiding this comment.
Hm, I think we can achieve the same without dropping top-level aliases -- let me check something...
|
Done -- I returned aliases for all old |
|
It seems that |
|
Sadly no luck. I've reverted wineStaging to 32-bit only. Merging in few days unless anybody has a better idea. |
abbradar
force-pushed
the
wine-reorder
branch
2 times, most recently
from
2a2a4bf to
ed3944c
Compare
Move most of wine configurations to winePackages which is not built on Hydra. Leave two top-level packages: wine: stable release with an "office" configuration; wineStaging: staging release with a "full" configuration.
Move most of wine configurations to
winePackageswhich are not built on Hydra.Leave two top-level packages:
wine: stable release with an "office" configuration;
wineStaging: staging release with a "full" configuration.
Motivation for this change
Fixes #26041.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)winestill building on my machine;wineStagingworks.