top-level/python-packages: add zip support to fetchPypi #26059
Closed
+3
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Because there are still older archives out there that use other extensions, like
Because that is what https://pypi.org/ offers. But restricting to that is not necessary though. |
|
Fixed. |
|
Thanks. I pushed 65477dc. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Currently, fetchPypi only supports tar.gz source distributions. This commit adds support for zip source distribution which can be enabled by passing tgz = false; to fetchPypi. Tested with 3to2 and fonttools (both packages with new versions only available in zipped form).
@FRidh fetchPypi only supporting sha256 checksums seems weird, is there any reason for that?
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)