vlc: 2.2.4 -> 2.2.5.1 with fix for subtitle vulnerability #26047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a nasty vulnerability caused by broken subtitle handling: http://blog.checkpoint.com/2017/05/23/hacked-in-translation/ (cherry picked from commit 4e2b190)
|
@peterhoeg, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fpletz, @edolstra and @domenkozar to be potential reviewers. |
|
Incredible. Applying, thank you! |
adrianpk
added a commit
to adrianpk/nixpkgs
that referenced
this pull request
May 31, 2024
vlc: 2.2.4 -> 2.2.5.1 with fix for subtitle vulnerability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
http://blog.checkpoint.com/2017/05/23/hacked-in-translation/
I have tried it out on unstable incl
nox-review wipbut I'm guessing weneed this badly on stable too.
cc: @grahamc
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)