pythonPackages.pytest-localserver: 0.3.5 -> 0.3.7 #26238
Merged
+34
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@matthiasbeyer, thanks for your PR! By analyzing the history of the files in this pull request, we identified @FRidh to be a potential reviewer. |
FRidh
requested changes
May 30, 2017
pkgs/top-level/python-packages.nix
Outdated
| @@ -5281,11 +5281,11 @@ in { | |||
|
|
|||
| pytest-localserver = buildPythonPackage rec { | |||
| name = "pytest-localserver-${version}"; | |||
There was a problem hiding this comment.
Can you move this expression to pkgs/development/python-modules/pytest-localserver/default.nix. See other files there on what to do with pname.
pkgs/top-level/python-packages.nix
Outdated
| @@ -5281,11 +5281,11 @@ in { | |||
|
|
|||
| pytest-localserver = buildPythonPackage rec { | |||
| name = "pytest-localserver-${version}"; | |||
| version = "0.3.5"; | |||
| version = "0.3.7"; | |||
|
|
|||
| src = pkgs.fetchurl { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
This patch is based on the
nixos-unstablebranch.Motivation for this change
Closes #26237
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)Artificially tested (by building). Going to rebuild my system with this patch now and reporting back then.