-
-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENV.replace not working as expected #4634
Comments
Thanks Nate, reading through comments and some code its not clear what exactly is the problem. |
Aren't The single file (which is a test file) that changed in that referenced pull request seems to contain many instances of tests being skipped if JRuby and Windows are detected. Maybe this is an issue of code being run when it shouldn't. |
Nothing obvious from the error, but this seems like some encoding oddity. However I was unable to make MRI produce any ENV strings in ASCII-8BIT, even when forced to be.
|
I'm confused about the line numbers in that build. When I clone puma master, there is no line 254 in test/test_integration.rb. The failing test is in there, but has a So...not sure what to do on JRuby's end. |
Thanks for looking at this guys. I filed this issue just kinda quickly so what looked like a possible JRuby bug didn't get lost in the shuffle. I'll do some work to clear things up on what's ahppening on our side. |
recent Puma built seems to be all green using 9.1.17.0 as well as jruby-head (9.2.1.DEV) |
Environment
TravisCI build with failure
Expected/Actual Behavior
puma/puma#1305
The text was updated successfully, but these errors were encountered: