Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

services.graphite: chmod -R entire dataDir #26247

Merged
merged 1 commit into from
May 30, 2017
Merged

services.graphite: chmod -R entire dataDir #26247

merged 1 commit into from
May 30, 2017

Conversation

apeschar
Copy link
Contributor

@apeschar apeschar commented May 30, 2017 •
edited

Motivation for this change

The Graphite web interface fails with attempt to write a readonly database because its SQLite3 is initialised as root and never chowned.

That's done now, so it all works.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@apeschar, thanks for your PR! By analyzing the history of the files in this pull request, we identified @offlinehacker, @bjornfor and @edolstra to be potential reviewers.

@apeschar
Copy link
Contributor Author

Before:

> ls -l /var/db/graphite                                                       ~
total 232
-rw-r--r-- 1 root     root          0 May 30 18:38 db-created
-rw-r--r-- 1 root     root     229376 May 30 18:38 graphite.db
-rw-r--r-- 1 root     root          0 May 30 18:38 index
drwxr-xr-x 3 graphite graphite   4096 May 30 18:38 log
drwx------ 6 graphite graphite   4096 May 30 18:39 whisper

After:

> ls -l /var/db/graphite                                                       ~
total 232
-rw-r--r-- 1 root     root          0 May 30 18:49 db-created
-rw-r--r-- 1 graphite graphite 229376 May 30 18:49 graphite.db
-rw-r--r-- 1 graphite graphite      0 May 30 18:49 index
drwxr-xr-x 3 graphite graphite   4096 May 30 18:49 log
drwx------ 2 graphite graphite   4096 May 30 18:49 whisper

@fpletz
Copy link
Member

fpletz commented May 30, 2017

Thanks!

@fpletz fpletz merged commit 39a1213 into NixOS:master May 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@apeschar @mention-bot @fpletz