Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

networkmanager_dmenu: unstable-2017-04-13 -> unstable-2017-05-28 #26239

Merged
merged 1 commit into from Jun 3, 2017
Merged

networkmanager_dmenu: unstable-2017-04-13 -> unstable-2017-05-28 #26239

merged 1 commit into from Jun 3, 2017

Conversation

jensbin
Copy link
Contributor

@jensbin jensbin commented May 30, 2017

Motivation for this change
  • Handle unicode AP names.
  • Only use rofi_highlight when config file says to
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 merged commit c0f2e13 into NixOS:master Jun 3, 2017
@jensbin jensbin deleted the networkmanager-dmenu_20170528 branch June 4, 2017 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jensbin @Mic92