Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better panorama thumbnails #2788

Merged
merged 1 commit into from May 22, 2017
Merged

Better panorama thumbnails #2788

merged 1 commit into from May 22, 2017

Conversation

ralsina
Copy link
Member

@ralsina ralsina commented May 22, 2017

Fix #2780

Kwpolska
Kwpolska approved these changes May 22, 2017
View reviewed changes
Copy link
Member

@Kwpolska Kwpolska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. (Bonus points for making those keyword arguments in process_image)

@ralsina
Copy link
Member Author

ralsina commented May 22, 2017

@Kwpolska they already are kwargs, we are just calling it positionally :-P

I don't want to run git blame because I fear this brokedness is all my doing.

@ralsina ralsina merged commit e4c5336 into master May 22, 2017
@Kwpolska Kwpolska deleted the fix-2780x2 branch May 22, 2017 13:51
@Kwpolska
Copy link
Member

Well, we weren’t always calling it positionally… It’s a simple mistake. No hard feelings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kwpolska Kwpolska Kwpolska approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ralsina @Kwpolska