Use BaguetteBox in base theme #2791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kwpolska
reviewed
May 22, 2017
| @@ -20,7 +20,13 @@ ${template_hooks['extra_head']()} | |||
| ${footer.html_footer()} | |||
| </div> | |||
| ${base.late_load_js()} | |||
| % if use_cdn: | |||
| <script src="//cdnjs.cloudflare.com/ajax/libs/baguettebox.js/1.8.2/baguetteBox.min.js"></script> | |||
There was a problem hiding this comment.
This keeps it protocol-relative, is https better? It used to give a mixed-content warning :-P
There was a problem hiding this comment.
protocol-relative stopped being cool a while back. Using httpS never gave mixed-content warnings, only http did.
|
Are captions supported if we wanted them? |
|
@Kwpolska yes, they are |
|
I have NO IDEA why this is failing. |
added 13 commits
May 24, 2017 21:01
|
(PS. CSSLint is pretty crazy, so I nuked it.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a nice, lightweight lightbox to the base theme.
Very conservative branch: no changes in bootstrap3, no captions, just the very barebones support.