Skip to content

eccodes: Provide python bindings #25992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 7, 2017

Conversation

knedlsepp
Copy link
Member

Motivation for this change

This provides python bindings for the eccodes library.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@@ -6379,6 +6379,14 @@ in {
};
};

eccodes = if (isPy27) then
(pkgs.eccodes.overrideDerivation (oldattrs: {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overrideAttrs

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@knedlsepp knedlsepp force-pushed the provide-eccodes-python-bindings branch from 8cfb3d0 to abdaf5a Compare May 22, 2017 14:43
@knedlsepp
Copy link
Member Author

@FRidh: Would you consider merging?

@FRidh FRidh merged commit 9ed3ad1 into NixOS:master Jun 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants