concat: init #26699
Closed
concat: init #26699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
is this different from buildEnv? |
Mic92
reviewed
Jun 19, 2017
| # | ||
| # { | ||
| # nixpkgs.config.packageOverrides = super: { | ||
| # hello = pkgs.concat "hello" [ |
There was a problem hiding this comment.
As this function is added to a rather big namespace, a more distinctive name is useful.
How about pkgs.concatPackages?
There was a problem hiding this comment.
Yes, EDIT: ignore my confusion of namespaces.lib.concat already exists (!)
|
The functionality provided by this function overlaps with |
|
Indeed, this is just name: paths: symlinkJoin {
inherit name paths;
}🦅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The
concatbuilder was introduced to allow creating wrapper derivations that retain access to other resources, like manpages.Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)