Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow OSX failures on Travis CI #4528

Merged

Conversation

Sija
Copy link
Contributor

@Sija Sija commented Jun 7, 2017

@matiasgarciaisaia
Copy link
Member

There are two main reasons to not merge this by now.

  1. We're testing if the CircleCI plan's limits are enough for us. There's a "build minutes per month" limit that we still don't know if are enough for us or not.
  2. We're working with TravisCI (really awesome) support to learn why the Xcode 8.2 builds are randomly failing while trying to brew install llvm. I'm in contact with them, and hopefully will have an answer soon.

So I say we should wait 👍

@matiasgarciaisaia
Copy link
Member

On second thought - we should allow failures for xcode 8.2 until it gets fixed.

@Sija
Copy link
Contributor Author

Sija commented Jun 7, 2017

Builds #8674, #8678 and #8746 failed on osx too.

@Sija
Copy link
Contributor Author

Sija commented Jun 7, 2017

We could add all osx section to allow_failures for now...

@matiasgarciaisaia
Copy link
Member

Be my guest:

diff --git a/.travis.yml b/.travis.yml
index 55502d412..99495506c 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -3,6 +3,7 @@ sudo: required
 dist: trusty
 services:
   - docker
+os: # need to declare on top level for `allow_failures` to work
 matrix:
   include:
     - env: ARCH=i386 ARCH_CMD=linux32
@@ -12,6 +13,8 @@ matrix:
     - os: osx
     - os: osx
       osx_image: xcode8.2
+  allow_failures:
+    - os: osx
   fast_finish: true
 before_install:
   - bin/ci prepare_system

@Sija
Copy link
Contributor Author

Sija commented Jun 7, 2017

I'm wondering is os the proper top-level key? Travis CI documentation mentions env key, but no os. Am I missing sth?

@Sija Sija force-pushed the remove-osx-from-travis-ci branch 2 times, most recently from ac3d7e2 to 7809d5a Compare June 8, 2017 12:12
@Sija Sija force-pushed the remove-osx-from-travis-ci branch from 7809d5a to 7eabdcf Compare June 8, 2017 12:18
@Sija Sija changed the title Remove OSX from Travis CI Allow OSX failures on Travis CI Jun 8, 2017
@Sija
Copy link
Contributor Author

Sija commented Jun 8, 2017

@matiasgarciaisaia I've pushed changes moving osx builds into allowed_failures section which seems to work (without adding os top-level key you suggested).

@Sija
Copy link
Contributor Author

Sija commented Jun 24, 2017

ping?

@sdogruyol
Copy link
Member

Is there any blocker for this to be merged? @matiasgarciaisaia

@matiasgarciaisaia
Copy link
Member

👍 LGTM. Thanks for the PR!

@matiasgarciaisaia matiasgarciaisaia added this to the 0.23.1 milestone Jul 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants