Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos-artwork: add more wallpapers #26460

Merged
merged 1 commit into from
Jun 13, 2017
Merged

nixos-artwork: add more wallpapers #26460

merged 1 commit into from
Jun 13, 2017

Conversation

romildo
Copy link
Contributor

@romildo romildo commented Jun 7, 2017

Motivation for this change

nixos-artwork has some NixOS artwork. The package nixos-artwork includes only the Gnome_Dark wallpaper.

This PR restructures the nixos-artwork package to make it easy to selectively incorporate other components from upstream without needing to download the full package.

Until now only the Gnome_Dark wallpaper was included. Add other wallpapers available in the package repository.

This has been previously discussed in 48381b7 and 248a1b4.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Restructure the nixos-artwork to make it easy to selectively
incorporate other components from upstream without needing to download
the full package.

Until now only the Gnome_Dark wallpaper was included. Add other
wallpapers available in the package repository.
@mention-bot
Copy link

@romildo, thanks for your PR! By analyzing the history of the files in this pull request, we identified @wkennington, @lethalman and @domenkozar to be potential reviewers.

@joachifm joachifm merged commit 631ec73 into NixOS:master Jun 13, 2017
@romildo romildo deleted the fix.nixos-artwork branch June 14, 2017 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants