Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add iana considerations section #71

Closed
wants to merge 1 commit into from

Conversation

dericed
Copy link
Contributor

@dericed dericed commented Jun 7, 2017

No description provided.

@JeromeMartinez
Copy link
Contributor

I think we need some IANA registration, or at least some codec info for IETF formats, I added a comment on CELLAR list: https://www.ietf.org/mail-archive/web/cellar/current/msg01168.html

@dericed
Copy link
Contributor Author

dericed commented Feb 4, 2018

updated for a new review

ffv1.md Outdated

See [the "Security Considerations" section](#security-considerations) of RFC xxxx.

[RFC Editor: Upon publication as an RFC, please replace "XXXX" with the number assigned to this document and remove this note.]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the need to indicate the number of this RFC here if it stays in the same RFC? I suggest to remove " of RFC xxxx".


This parameter is used to signal the capabilities of a receiver implementation. This parameter MUST NOT be used for any other purpose.

version: The version of the FFV1 encoding as defined by [in the section on `version`](#version).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would put version[.micro_version].

Similar to https://www.iana.org/assignments/media-types/video/H264 parameters, I would add coder_type, color_space and bits_per_raw_sample, as some decoders may support only some combinations or we may add new coder_type, color_space in the future (like H.264 decoders support only some profiles and/or levels and standard adds new profiles later). Adding chroma subsampling info and others is maybe too much?

Reading IANA consideration for H264, max-fs (frame size), max-br (bit rate), something about max count of slices, could be taken into consideration.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the pr is updated to consider this comment. please re-review.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine for me but willing another pair of eyes on it, I am not confident enough that I saw everything.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx, I suspect we'll get a better review when reviewed by the area director or iesg, but for now I hope we have consensus amongst participating contributors/reviewers.

ffv1.md Outdated

Restrictions on usage: None.

Author: TODO [Pick a contact]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michaelni, may I set you as the IANA contact?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dericed, what does the IANA contact has to do ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @michaelni, the definition of the contact in the media type registration from rfc4855 is only

Person (including contact information) to contact for further information.

IIUC this contact only applies to the media type registration of IANA, but if IANA has some questions during the registration they need a specific contact. If you'd rather not, I could volunteer.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ohh, ok, feel free to add me

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michaelni I added you as contact and myself as the author of the registration section.

@dericed dericed mentioned this pull request Feb 12, 2018
@dericed
Copy link
Contributor Author

dericed commented Feb 12, 2018

Updated to add contact names, please re-review.

@michaelni michaelni closed this in 4b664e7 Feb 12, 2018
@michaelni
Copy link
Member

this breaks build, please test build before approving changes

draft-ietf-cellar-ffv1-01.xml: Line 1490: IDREF attribute target references an unknown ID "color_space"
draft-ietf-cellar-ffv1-01.xml: Line 1488: IDREF attribute target references an unknown ID "coder_type"
draft-ietf-cellar-ffv1-01.xml: Line 1492: IDREF attribute target references an unknown ID "bits_per_raw_sample"
draft-ietf-cellar-ffv1-01.xml: Line 1486: IDREF attribute target references an unknown ID "micro_version"

@michaelni
Copy link
Member

It seems the _ are lost in the anchors, i wonder how that happens

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants