Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

firefox-*-bin: updates #26462

Merged
merged 2 commits into from
Jun 8, 2017
Merged

firefox-*-bin: updates #26462

merged 2 commits into from
Jun 8, 2017

Conversation

garbas
Copy link
Member

@garbas garbas commented Jun 7, 2017 •
edited

  • firefox-beta-bin: 51.0b8 -> 54.0b13

  • firefox-devedition-bin: init at 54.0b14

Firefox DevEdition became a new product of Mozilla and is "repackaged"
Firefox Beta with its own release channel and six weeks release cycle as
other channels. It is no longer being built on nightly basis

  • updated the update.nix script to facilitata firefox-devedition-bin

  • disabling automatic updates by pointing to non existing channel

Motivation for this change
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@garbas
firefox-*-bin: updates
bcd0918 
* firefox-beta-bin: 51.0b8 -> 54.0b13

* firefox-devedition-bin: init at 54.0b14

Firefox DevEdition became a new product of Mozilla and is "repackaged"
Firefox Beta with its own release channel and six weeks release cycle as
other channels. It is no longer being built on nightly basis

* updated the update.nix script to facilitata firefox-devedition-bin

* disabling automatic updates by pointing to non existing channel
@garbas garbas requested review from nbp and grahamc June 7, 2017 22:04
@grahamc
Copy link
Member

grahamc commented Jun 7, 2017

LGTM but I haven't tested it. I will do that later today if the PR is still open :)

@garbas
Copy link
Member Author

garbas commented Jun 8, 2017

I found the error which was already present before this update, but nevertheless i might ask here how fix it. If you open any Browser button where file selector shows up, then all channels of firefox-bin crash. I'm probably missing some dependency which is loaded dynamically, but I'm yet to learn how to detect this.

And for those who are looking for Firefox Nightly, look no further then github.commozilla/nixpkgs-mozilla :) and wow does nightly works faster.

@garbas
Copy link
Member Author

garbas commented Jun 8, 2017

hmm ... having a browser dialog works on nightly. i wonder what am i missing here.

@7c6f434c
Copy link
Member

7c6f434c commented Jun 8, 2017

Hm… Does firefox-bin set gtk3 attribute on the unwrapped version? I think wrapFirefox sets XDG_DATA_DIRS needed by gtk3 only when browser.gtk3 attribute exists.

@garbas
Copy link
Member Author

garbas commented Jun 8, 2017

@7c6f434c tnx for the pointer. i just inherit gtk3 in firefox-bin/default.nix (see last commit in this PR) and that fixed the problem. would this be ok solution?

@7c6f434c
Copy link
Member

7c6f434c commented Jun 8, 2017

Well, the main derivation adds it to passthru, but as it is a dependency already the difference is negligible.

@garbas garbas merged commit a0afc4f into NixOS:master Jun 8, 2017
@garbas garbas deleted the firefox-bin-update branch June 8, 2017 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbp nbp Awaiting requested review from nbp

@grahamc grahamc Awaiting requested review from grahamc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@garbas @grahamc @7c6f434c